fix(ng-dev): set _ as the username in the URL when creating authent…

…icated git URLs

Github requires that both the username and password values are provided when setting a
remote as an authenticated URL.

Previously we did not see any issues with how we set authentication for because all usages of our tooling
was performed in an environment that already had authentication set up, so if the authentication didn't
work via the remote url, git just used the git cached credentials.

ng-dev/utils/git/github-urls.ts

@@ -20,7 +20,8 @@ export const GITHUB_TOKEN_GENERATE_URL = 'https://github.com/settings/tokens/new
 /** Adds the provided token to the given Github HTTPs remote url. */
 export function addTokenToGitHttpsUrl(githubHttpsUrl: string, token: string) {
   const url = new URL(githubHttpsUrl);
-  url.username = token;
+  url.password = token;
+  url.username = '_';
   return url.href;
 }
 

ng-dev/utils/testing/virtual-git-matchers.ts

@@ -27,13 +27,13 @@ export function getBranchPushMatcher(options: BranchPushMatchParameters) {
   const {targetRepo, targetBranch, baseBranch, baseRepo, expectedCommits} = options;
   return jasmine.objectContaining({
     remote: {
-      repoUrl: `https://[email protected]/${targetRepo.owner}/${targetRepo.name}.git`,
+      repoUrl: `https://_:[email protected]/${targetRepo.owner}/${targetRepo.name}.git`,
       name: `refs/heads/${targetBranch}`,
     },
     head: jasmine.objectContaining({
       newCommits: expectedCommits,
       ref: {
-        repoUrl: `https://[email protected]/${baseRepo.owner}/${baseRepo.name}.git`,
+        repoUrl: `https://_:[email protected]/${baseRepo.owner}/${baseRepo.name}.git`,
         name: baseBranch,
       },
     }),