Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slider): unable to reset value by setting it back to undefined #9768

Merged
merged 1 commit into from
Feb 8, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Feb 3, 2018

Fixes the slider value not being reset to zero if the consumer sets it to undefined.

Fixes #9740.

Fixes the slider value not being reset to zero if the consumer sets it to undefined.

Fixes angular#9740.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 3, 2018
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed pr: needs review labels Feb 3, 2018
@mmalerba mmalerba merged commit 171486e into angular:master Feb 8, 2018
@ClivePixton
Copy link

Thanks, you guys rock!!

mmalerba pushed a commit that referenced this pull request Feb 8, 2018
…9768)

Fixes the slider value not being reset to zero if the consumer sets it to undefined.

Fixes #9740.
tinayuangao pushed a commit that referenced this pull request Feb 9, 2018
…9768)

Fixes the slider value not being reset to zero if the consumer sets it to undefined.

Fixes #9740.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot set slider value back to undefined
4 participants