fix(focus-monitor): clear all pending timeouts when unregistering global listeners #9542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
mmalerba
reviewed
Jan 23, 2018
src/cdk/a11y/focus-monitor.ts
Outdated
| @@ -202,7 +201,7 @@ export class FocusMonitor implements OnDestroy { | |||
|
|
|||
| // Note: we listen to events in the capture phase so we can detect them even if the user stops | |||
| // propagation. | |||
| this._ngZone.runOutsideAngular(() => { | |||
| Zone.root.run(() => { | |||
There was a problem hiding this comment.
comment about why we need to do this
josephperrott
force-pushed
the
focus-monitor-zone
branch
from
deda78b
to
7b6e079
Compare
josephperrott
changed the title
josephperrott
force-pushed
the
focus-monitor-zone
branch
from
7b6e079
to
31a3598
Compare
josephperrott
force-pushed
the
focus-monitor-zone
branch
from
31a3598
to
2d24f3e
Compare
|
This should be ready to look at again as it now clears the timeouts that are created on destruction. |
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.