-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: move from angular-cli to gulp #948
Changes from all commits
71d825f
99dace8
3c6bd6a
0234c66
6b5c0ee
2460923
c2d482e
10dd65f
5d26341
95cbb1a
3ae36f3
f3c435d
dfb27d7
1324d24
a8cfa67
17c1131
a4303e3
cc95bd9
f0b3825
4ba2502
7800a52
8b056e6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
'use strict'; | ||
/** | ||
* Load the TypeScript compiler, then load the TypeScript gulpfile which simply loads all | ||
* the tasks. The tasks are really inside tools/gulp/tasks. | ||
*/ | ||
|
||
const path = require('path'); | ||
|
||
// Register TS compilation. | ||
require('ts-node').register({ | ||
project: path.join(__dirname, 'tools/gulp') | ||
}); | ||
|
||
require('./tools/gulp/gulpfile'); |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,42 +14,12 @@ start_tunnel | |
|
||
wait_for_tunnel | ||
if is_lint; then | ||
npm run tslint | ||
npm run ci:forbidden-identifiers | ||
npm run stylelint | ||
elif is_circular_deps_check; then | ||
# Build first because madge needs the JavaScript output. | ||
ng build | ||
npm run check-circular-deps | ||
$(npm bin)/gulp ci:lint | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure if this would work, but could you add at the beginning There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd rather not even put the time. This file will be going away in the next PR. |
||
elif is_e2e; then | ||
# Start up the e2e app. This will take some time. | ||
echo "Starting e2e app" | ||
MD_APP=e2e ng serve & | ||
sleep 1 | ||
|
||
# Wait until the dist/ directory is created, indicating that the e2e app is ready. | ||
# Use the presence of `button.js` to determine whether the compiled output is ready to be served. | ||
echo "Waiting for e2e app to start" | ||
while [ ! -f ./dist/components/button/button.js ]; do | ||
sleep 2 | ||
echo -n ".." | ||
done | ||
|
||
echo "\nInlining resources" | ||
npm run inline-resources | ||
|
||
# Run the e2e tests on the served e2e app. | ||
echo "Starting e2e tests" | ||
ng e2e | ||
$(npm bin)/gulp ci:e2e | ||
elif is_extract_metadata; then | ||
# Run `tsc` first so that the directory structure in dist/ matches what ngc expects. | ||
./node_modules/.bin/tsc -p ./src/demo-app/ | ||
./node_modules/.bin/ngc -p ./src/demo-app/ | ||
$(npm bin)/gulp ci:extract-metadata | ||
else | ||
# Unit tests | ||
npm run build | ||
npm run inline-resources | ||
|
||
karma start test/karma.conf.js --single-run --no-auto-watch --reporters='dots' | ||
$(npm bin)/gulp ci:test | ||
fi | ||
teardown_tunnel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a comment here pointing people to the appropriate location for the tasks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.