Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(overlay): validate that ConnectedPositionStrategy positions are passed in correctly at runtime #9466

Merged
merged 1 commit into from
Feb 8, 2018
Merged

fix(overlay): validate that ConnectedPositionStrategy positions are passed in correctly at runtime #9466

merged 1 commit into from
Feb 8, 2018

Commits on Jan 19, 2018

  1. fix(overlay): validate that ConnectedPositionStrategy positions are p… 

    …assed in correctly at runtime

Since we have some cases where we pass in positions verbatim to the connected position strategy (the connected position directive), we could end up in a situation where the consumer passed in a set of invalid positions that don't break necessarily, but don't work correctly either. These changes add some sanity checks at runtime to make debugging easier.
    @crisbeto
    crisbeto committed Jan 19, 2018
    Configuration menu
    Copy the full SHA
    e6a5dd1 View commit details
    Browse the repository at this point in the history