fix(overlay): server-side rendering error when creating backdrop element #9448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
|
@crisbeto passes Google presubmit, but Travis looks to have some failures related to this PR |
Avoids a couple of server-side rendering errors when the overlay's backdrop is being created.
crisbeto
force-pushed
the
overlay-backdrop-ssr-error
branch
from
3581f0f
to
6c45563
Compare
|
Rebased and sorted out the test failure. |
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
Jan 29, 2018
…ent (angular#9448) Avoids a couple of server-side rendering errors when the overlay's backdrop is being created.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids a couple of server-side rendering errors when the overlay's backdrop is being created.