fix(autocomplete): close panel using alt + up arrow #9341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
approved these changes
Jan 11, 2018
| @@ -280,9 +280,9 @@ export class MatAutocompleteTrigger implements ControlValueAccessor, OnDestroy { | |||
| _handleKeydown(event: KeyboardEvent): void { | |||
| const keyCode = event.keyCode; | |||
|
|
|||
| if (keyCode === ESCAPE && this.panelOpen) { | |||
| if (this.panelOpen && (keyCode === ESCAPE || (keyCode === UP_ARROW && event.altKey))) { | |||
There was a problem hiding this comment.
Similar comment to the select about alt + arrow key?
[Based on the accessibility guidelines](https://www.w3.org/TR/wai-aria-practices-1.1/#textbox-keyboard-interaction), the autocomplete panel can be closed using the alt + up arrow keyboard combo.
crisbeto
force-pushed
the
autocomplete-alt-up-arrow
branch
from
1c07f12
to
4e4e413
Compare
crisbeto
added
Accessibility
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
Jan 29, 2018
[Based on the accessibility guidelines](https://www.w3.org/TR/wai-aria-practices-1.1/#textbox-keyboard-interaction), the autocomplete panel can be closed using the alt + up arrow keyboard combo.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the accessibility guidelines, the autocomplete panel can be closed using the alt + up arrow keyboard combo.