fix(datepicker): not resetting when detached externally #9133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
datepicker-programmatic-detachments
branch
from
def027c
to
cd45a19
Compare
mmalerba
approved these changes
Dec 28, 2017
mmalerba
added
pr: lgtm
action: merge
Fixes not being able to reopen a datepicker if it's detached via the `OverlayRef` (e.g. by a `CloseScrollStrategy`).
crisbeto
force-pushed
the
datepicker-programmatic-detachments
branch
from
cd45a19
to
e11e161
Compare
jelbourn
added
target: minor
|
Changing this to minor release since it doesn't cleanly cherry-pick into the patch branch |
tinayuangao
pushed a commit
that referenced
this pull request
Jan 10, 2018
Fixes not being able to reopen a datepicker if it's detached via the `OverlayRef` (e.g. by a `CloseScrollStrategy`).
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes not being able to reopen a datepicker if it's detached via the
OverlayRef(e.g. by aCloseScrollStrategy).