Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tree): Use tabindex for tree node #9042

Merged
merged 1 commit into from
Dec 19, 2017
Merged

feat(tree): Use tabindex for tree node #9042

merged 1 commit into from
Dec 19, 2017

Conversation

tinayuangao
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 18, 2017
jelbourn
jelbourn approved these changes Dec 19, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, add merge-ready when ready

src/lib/tree/node.ts Outdated
@Attribute('tabindex') tabIndex: string) {
super(_elementRef, _tree);

this.tabIndex = parseInt(tabIndex) || 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer Number(tabIndex) to parseInt
(here and below)

@tinayuangao tinayuangao added the action: merge The PR is ready for merge by the caretaker label Dec 19, 2017
@tinayuangao tinayuangao merged commit b04d648 into angular:tree Dec 19, 2017
tinayuangao added a commit that referenced this pull request Dec 19, 2017
@tinayuangao
feat(tree): Use tabindex for tree node (#9042)
8116194
tinayuangao added a commit that referenced this pull request Jan 4, 2018
@tinayuangao
feat(tree): Use tabindex for tree node (#9042)
958dbce
tinayuangao added a commit that referenced this pull request Jan 10, 2018
@tinayuangao
feat(tree): Use tabindex for tree node (#9042)
36bdae3
tinayuangao added a commit that referenced this pull request Jan 23, 2018
@tinayuangao
feat(tree): Use tabindex for tree node (#9042)
d7b802d
tinayuangao added a commit that referenced this pull request Feb 5, 2018
@tinayuangao
feat(tree): Use tabindex for tree node (#9042)
6be9bac
tinayuangao added a commit that referenced this pull request Feb 9, 2018
@tinayuangao
feat(tree): Use tabindex for tree node (#9042)
c361e10
jelbourn pushed a commit that referenced this pull request Feb 12, 2018
@tinayuangao @jelbourn
feat(tree): Use tabindex for tree node (#9042)
cfed0aa
tinayuangao added a commit that referenced this pull request Feb 13, 2018
@tinayuangao
feat(tree): Use tabindex for tree node (#9042)
f8db458
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tinayuangao @jelbourn @googlebot