fix(select): support using shift + arrow key to toggle items in a multi-select #9037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
Accessibility
googlebot
added
the
cla: yes
jelbourn
reviewed
Dec 18, 2017
|
|
||
| if (this._multiple && isArrowKey && event.shiftKey && this._keyManager.activeItem && | ||
| this._keyManager.activeItemIndex !== previouslyFocusedIndex) { | ||
| this._keyManager.activeItem._selectViaInteraction(); |
There was a problem hiding this comment.
Should the key manager do this?
There was a problem hiding this comment.
The key manager currently doesn't have a concept of what is selected, it only knows what is focused/highlighted.
jelbourn
added
pr: lgtm
action: merge
…ti-select Based on the accessibility guidelines for a multi-selection listbox (https://www.w3.org/TR/wai-aria-practices-1.1/#Listbox), potentially we can support toggling the previous/next item if the user presses shift + up/down arrow.
crisbeto
force-pushed
the
select-shift-arrow-selection
branch
from
f6a5695
to
4adba9c
Compare
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
Jan 8, 2018
…ti-select (angular#9037) Based on the accessibility guidelines for a multi-selection listbox (https://www.w3.org/TR/wai-aria-practices-1.1/#Listbox), potentially we can support toggling the previous/next item if the user presses shift + up/down arrow.
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
Jan 9, 2018
…ti-select (angular#9037) Based on the accessibility guidelines for a multi-selection listbox (https://www.w3.org/TR/wai-aria-practices-1.1/#Listbox), potentially we can support toggling the previous/next item if the user presses shift + up/down arrow.
jelbourn
pushed a commit
that referenced
this pull request
Jan 9, 2018
…ti-select (#9037) Based on the accessibility guidelines for a multi-selection listbox (https://www.w3.org/TR/wai-aria-practices-1.1/#Listbox), potentially we can support toggling the previous/next item if the user presses shift + up/down arrow.
tinayuangao
pushed a commit
that referenced
this pull request
Jan 10, 2018
…ti-select (#9037) Based on the accessibility guidelines for a multi-selection listbox (https://www.w3.org/TR/wai-aria-practices-1.1/#Listbox), potentially we can support toggling the previous/next item if the user presses shift + up/down arrow.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the accessibility guidelines for a multi-selection listbox (https://www.w3.org/TR/wai-aria-practices-1.1/#Listbox), potentially we can support toggling the previous/next item if the user presses shift + up/down arrow.