fix(stepper): use up/down arrows for navigating vertical stepper #8920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
Accessibility
googlebot
added
the
cla: yes
|
Should the horizontal arrows still work for the vertical stepper? The way they worded it, it sounds kind of like up/down are an extra feature for vertical, but they all support left/right:
|
|
Hmm I see what you mean, but it seems a little counter-intuitive. |
|
I can see how users would want it though. I suspect if I relied primarily on keyboard for navigation I wouldn't want to have to think about what direction my tabs are, I would just want my right/left to do the same thing as usual |
crisbeto
force-pushed
the
vertical-stepper-keyboard-nav
branch
from
99a350d
to
a3e3d87
Compare
Currently both vertical and horizontal steppers use the left/right arrows to move focus steps. Based on the a11y guidelines (https://www.w3.org/TR/wai-aria-practices-1.1/#tabpanel) the vertical stepper should use the up/down arrows instead.
crisbeto
force-pushed
the
vertical-stepper-keyboard-nav
branch
from
a3e3d87
to
f329693
Compare
|
Makes sense. I've put back the left/right behavior for the vertical one and added the up/down on top. |
mmalerba
approved these changes
Dec 19, 2017
mmalerba
added
pr: lgtm
target: minor
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
Jan 8, 2018
…ular#8920) Currently both vertical and horizontal steppers use the left/right arrows to move focus steps. Based on the a11y guidelines (https://www.w3.org/TR/wai-aria-practices-1.1/#tabpanel) the vertical stepper should use the up/down arrows instead.
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
Jan 9, 2018
…ular#8920) Currently both vertical and horizontal steppers use the left/right arrows to move focus steps. Based on the a11y guidelines (https://www.w3.org/TR/wai-aria-practices-1.1/#tabpanel) the vertical stepper should use the up/down arrows instead.
jelbourn
pushed a commit
that referenced
this pull request
Jan 9, 2018
Currently both vertical and horizontal steppers use the left/right arrows to move focus steps. Based on the a11y guidelines (https://www.w3.org/TR/wai-aria-practices-1.1/#tabpanel) the vertical stepper should use the up/down arrows instead.
tinayuangao
pushed a commit
that referenced
this pull request
Jan 10, 2018
Currently both vertical and horizontal steppers use the left/right arrows to move focus steps. Based on the a11y guidelines (https://www.w3.org/TR/wai-aria-practices-1.1/#tabpanel) the vertical stepper should use the up/down arrows instead.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently both vertical and horizontal steppers use the left/right arrows to move focus between steps. Based on the a11y guidelines (https://www.w3.org/TR/wai-aria-practices-1.1/#tabpanel) the vertical stepper should use the up/down arrows instead.