Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(directionality): change event now emit the new value #8424

Merged
merged 1 commit into from
Dec 1, 2017
Merged

fix(directionality): change event now emit the new value #8424

merged 1 commit into from
Dec 1, 2017

Conversation

EladBezalel
Copy link
Member

No description provided.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 13, 2017
@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 13, 2017
jelbourn
jelbourn approved these changes Nov 13, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn removed the action: merge The PR is ready for merge by the caretaker label Nov 18, 2017
@jelbourn
Copy link
Member

@EladBezalel this has CI errors

@EladBezalel
Copy link
Member Author

fixed

jelbourn
jelbourn approved these changes Nov 28, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Nov 28, 2017
@tinayuangao tinayuangao merged commit 841f753 into angular:master Dec 1, 2017
@EladBezalel EladBezalel deleted the fix/directionality-emit-value branch March 4, 2018 16:13
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EladBezalel @jelbourn @googlebot @tinayuangao