Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(icon): remove IDs from source icon set from rendered output #8266

Merged
merged 1 commit into from
Nov 10, 2017
Merged

fix(icon): remove IDs from source icon set from rendered output #8266

merged 1 commit into from
Nov 10, 2017

Conversation

jelbourn
Copy link
Member

@jelbourn jelbourn commented Nov 7, 2017

Fixes #8265

@jelbourn jelbourn added Accessibility This issue is related to accessibility (a11y) pr: needs review labels Nov 7, 2017
@jelbourn jelbourn requested a review from kara as a code owner November 7, 2017 02:38
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 7, 2017
crisbeto
crisbeto approved these changes Nov 7, 2017
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Nov 7, 2017
@josephperrott josephperrott merged commit 76806e3 into angular:master Nov 10, 2017
@jelbourn jelbourn deleted the icon-set-remove-id branch April 2, 2018 22:30
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@kara kara Awaiting requested review from kara

Assignees
No one assigned
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Icons create duplicate ID across the page.
4 participants
@jelbourn @crisbeto @googlebot @josephperrott