feat(reposition-scroll-strategy): add option for closing once the user scrolls away #8233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Nov 8, 2017
| scrollThrottle?: number; | ||
|
|
||
| /** Whether to close the overlay once the user has scrolled away completely. */ | ||
| close?: boolean; |
crisbeto
force-pushed
the
reposition-scroll-close
branch
from
0593f40
to
ce32dcb
Compare
|
Renamed to |
jelbourn
added
pr: lgtm
action: merge
|
@crisbeto lint |
…r scrolls away Adds an option to the `RepositionScrollStrategy` that tells it to close the overlay once the user has scrolled away. This is a steps towards moving the scroll clipping logic away from the `ConnectedPositionStrategy`.
crisbeto
force-pushed
the
reposition-scroll-close
branch
from
ce32dcb
to
f3d3ba9
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to the
RepositionScrollStrategythat tells it to close the overlay once the user has scrolled away. This is a step towards moving the scroll clipping logic away from theConnectedPositionStrategy.Note: The new option is intended to be on by default, however a lot of components don't handle programmatic detachments correctly at the moment. They are being addressed in separate PRs (#8232, #7950).