fix(checkbox, slide-toggle): only emit change event if native input emitted one. #820

devversion · 2016-07-06T17:09:52Z

We should only emit a change event, when the native input element emitted one.

This makes sure that the given component matches the native browser behavior and doesn't emit a change event for example, when changing the native checked property.

FYI: This change is also required for the radio component, but this should be addressed in another PR, since this will require a bit more work, through the radio group.

References #791

jelbourn · 2016-07-12T22:40:09Z

@devversion could you rebase?

devversion · 2016-07-13T11:58:45Z

@jelbourn Done!

jelbourn · 2016-07-14T01:20:51Z

src/components/checkbox/checkbox.spec.ts

@@ -214,13 +213,47 @@ describe('MdCheckbox', () => {
      expect(testComponent.onCheckboxClick).toHaveBeenCalledTimes(1);
    });

-    it('should emit a change event when the `checked` value changes', async(() => {
+    it('should trigger the change event properly', async(() => {


"Property" isn't very specific. How about "should trigger a change event when the native input does" ?

Sounds good

jelbourn · 2016-07-14T01:24:30Z

LGTM besides the test name.

@robertmesserle I think this fix covers what you were doing in #739, any thoughts?

robertmesserle · 2016-07-14T01:34:33Z

@jelbourn @devversion I think so. Does this fix the nested checkbox demo? I was using that as a test-case that I wanted to support.

#575 has a good demo for what I was trying to fix.

devversion · 2016-07-14T05:11:49Z

@robertmesserle

Does this fix the nested checkbox demo?

Yeah, one minor thing needs to be fixed, because the (change) is now emitting a MdCheckboxChange class, instead of just the boolean.

#575 has a good demo for what I was trying to fix.

I tested that out, and it seems to work as well, when doing the adjustments for the MdCheckboxChange class.

jelbourn · 2016-07-14T23:34:57Z

LGTM, just needs a rebase.

googlebot · 2016-07-15T16:29:36Z

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

googlebot · 2016-07-15T16:29:36Z

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

googlebot · 2016-07-15T16:32:12Z

CLAs look good, thanks!

googlebot · 2016-07-15T16:32:12Z

CLAs look good, thanks!

… emitted one.

Fixes angular#575.

devversion · 2016-07-15T16:41:50Z

@jelbourn Uff, I accidentally had the Slider PR from testing in there. but I was able to fix the branch, so it's now rebased again 😄

angular-automatic-lock-bot · 2019-09-06T01:02:39Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 6, 2016

devversion force-pushed the fix/emit-native-change-event branch 3 times, most recently from b5c5424 to c79221c Compare July 6, 2016 18:59

devversion force-pushed the fix/emit-native-change-event branch from c79221c to a2141c4 Compare July 13, 2016 11:52

jelbourn reviewed Jul 14, 2016
View reviewed changes

jelbourn added the pr: needs review label Jul 14, 2016

devversion force-pushed the fix/emit-native-change-event branch from d847cf9 to ed51258 Compare July 14, 2016 18:59

jelbourn added pr: lgtm and removed pr: needs review labels Jul 14, 2016

This was referenced Jul 14, 2016

Checkbox Infinite Loop #812

Closed

fix(checkbox): should match native checkbox behavior #739

Closed

devversion force-pushed the fix/emit-native-change-event branch from ed51258 to 482aff1 Compare July 15, 2016 16:29

googlebot added cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Jul 15, 2016

devversion force-pushed the fix/emit-native-change-event branch from 482aff1 to d9f0025 Compare July 15, 2016 16:32

googlebot removed the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Jul 15, 2016

googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 15, 2016

devversion added 2 commits July 15, 2016 18:38

fix(): slide-toggle, checkbox should only emit events if native input…

d89916d

… emitted one.

Fix nested checkbox demo and update test name

e5b461b

Fixes angular#575.

devversion force-pushed the fix/emit-native-change-event branch from d9f0025 to e5b461b Compare July 15, 2016 16:39

Remove whitespace

e164dbb

jelbourn added action: merge The PR is ready for merge by the caretaker and removed pr: needs rebase labels Jul 15, 2016

kara merged commit d52e6e0 into angular:master Jul 15, 2016

devversion deleted the fix/emit-native-change-event branch July 15, 2016 18:38

ImAllInNow mentioned this pull request Aug 18, 2016

Changing value via [colorPicker] should not cause a (colorPickerChange) event to fire. Alberplz/angular2-color-picker#18

Closed

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(checkbox, slide-toggle): only emit change event if native input emitted one. #820

fix(checkbox, slide-toggle): only emit change event if native input emitted one. #820

devversion commented Jul 6, 2016

jelbourn commented Jul 12, 2016

devversion commented Jul 13, 2016

jelbourn Jul 14, 2016 •

edited

Loading

devversion Jul 14, 2016

jelbourn commented Jul 14, 2016

robertmesserle commented Jul 14, 2016 •

edited

Loading

devversion commented Jul 14, 2016

jelbourn commented Jul 14, 2016

googlebot commented Jul 15, 2016

googlebot commented Jul 15, 2016

googlebot commented Jul 15, 2016

googlebot commented Jul 15, 2016

devversion commented Jul 15, 2016

angular-automatic-lock-bot bot commented Sep 6, 2019

fix(checkbox, slide-toggle): only emit change event if native input emitted one. #820

fix(checkbox, slide-toggle): only emit change event if native input emitted one. #820

Conversation

devversion commented Jul 6, 2016

jelbourn commented Jul 12, 2016

devversion commented Jul 13, 2016

jelbourn Jul 14, 2016 • edited Loading

Choose a reason for hiding this comment

devversion Jul 14, 2016

Choose a reason for hiding this comment

jelbourn commented Jul 14, 2016

robertmesserle commented Jul 14, 2016 • edited Loading

devversion commented Jul 14, 2016

jelbourn commented Jul 14, 2016

googlebot commented Jul 15, 2016

googlebot commented Jul 15, 2016

googlebot commented Jul 15, 2016

googlebot commented Jul 15, 2016

devversion commented Jul 15, 2016

angular-automatic-lock-bot bot commented Sep 6, 2019

jelbourn Jul 14, 2016 •

edited

Loading

robertmesserle commented Jul 14, 2016 •

edited

Loading