Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dialog): don't block other dialogs from opening while animating #8051

Merged
merged 1 commit into from
Nov 2, 2017
Merged

fix(dialog): don't block other dialogs from opening while animating #8051

merged 1 commit into from
Nov 2, 2017

Commits on Oct 28, 2017

  1. fix(dialog): don't block other dialogs from opening while animating 

    The behavior where we don't allow new dialogs to be opened while a dialog is animating was introduced initially in angular#5769 to avoid issues where the user might open multiple dialogs by accident if they press enter one too many times. This is problematic because it also means that the consumer is blocked from opening dialogs for certain 300ms intervals. These changes approach the issue differently by moving focus onto the dialog container immediately while it's animating.

Fixes angular#6560.
    @crisbeto
    crisbeto committed Oct 28, 2017
    Configuration menu
    Copy the full SHA
    11e1358 View commit details
    Browse the repository at this point in the history