Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(overlay): CloseScrollStrategy not triggering change detection on close #7929

Merged
merged 1 commit into from
Nov 2, 2017
Merged

fix(overlay): CloseScrollStrategy not triggering change detection on close #7929

merged 1 commit into from
Nov 2, 2017

Commits on Oct 21, 2017

  1. fix(overlay): CloseScrollStrategy not triggering change detection on … 

    …close

After some refactoring, the `ScrollDispatcher` no longer dispatches inside the `NgZone`, which caused the `CloseScrollStrategy` to break, because it detaches without triggering change detection. These changes bring the detachment back into the `NgZone`.

Fixes angular#7922.
    @crisbeto
    crisbeto committed Oct 21, 2017
    Configuration menu
    Copy the full SHA
    0540592 View commit details
    Browse the repository at this point in the history