Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): support typing to select items on when closed #7885

Merged
merged 1 commit into from
Nov 2, 2017

Conversation

crisbeto
Copy link
Member

Adds support for selecting items on a closed select by typing. This is similar to how the native select works.

@crisbeto crisbeto added Accessibility This issue is related to accessibility (a11y) pr: needs review labels Oct 18, 2017
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 18, 2017
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Oct 26, 2017
Adds support for selecting items on a closed select by typing. This is similar to how the native select works.
@andrewseguin andrewseguin merged commit 8edb416 into angular:master Nov 2, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants