Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove compatibility mode #7689

Merged
merged 1 commit into from
Oct 27, 2017
Merged

refactor: remove compatibility mode #7689

merged 1 commit into from
Oct 27, 2017

Conversation

crisbeto
Copy link
Member

Since the switch to the mat- prefix, the compatibility mode is no longer necessary. These changes remove anything that was left.

BREAKING CHANGE:
The MATERIAL_COMPATIBILITY_MODE, CompatibilityModule, NoConflictStyleCompatibilityMode, MatPrefixRejector, MdPrefixRejector symbols have been removed.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 10, 2017
jelbourn
jelbourn approved these changes Oct 10, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed pr: needs review labels Oct 10, 2017
@jelbourn
Copy link
Member

Caretaker: the sync config might need to be tweaked

@crisbeto crisbeto removed the action: merge The PR is ready for merge by the caretaker label Oct 10, 2017
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Oct 10, 2017
@jelbourn jelbourn added the P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful label Oct 23, 2017
@crisbeto
refactor: remove compatibility mode
ada28e3 
Since the switch to the `mat-` prefix, the compatibility mode is no longer necessary. These changes remove anything that was left.

BREAKING CHANGE:
The `MATERIAL_COMPATIBILITY_MODE`, `CompatibilityModule`, `NoConflictStyleCompatibilityMode`, `MatPrefixRejector`, `MdPrefixRejector` symbols have been removed.
@mmalerba mmalerba merged commit dcef604 into angular:master Oct 27, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@amcdnl amcdnl Awaiting requested review from amcdnl

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @googlebot @mmalerba