-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dialog): support minWidth, minHeight, maxWidth and maxHeight #7488
Merged
Commits on Oct 3, 2017
-
feat(dialog): support minWidth, minHeight, maxWidth and maxHeight
* Adds Dialog support for `minWidth`, `minHeight`, `maxWidth` and `maxHeight` via config. Mostly delegates to Overlay. * Moves declared `max-width` on `. mat-dialog-container` stylesheet to be authored via `MatDialogConfig`, providing the same default `80vw` value. Without this change, there would likely be undesired layout results due to different constraints being set on the overlay container vs the nested the dialog container. * Added note on `minHeight` and `maxHeight` regarding the potential need to also set a `height` due to the rules around computed height resolution (https://www.w3.org/TR/CSS2/visudet.html#min-max-widths). Any value set on `height` as a default would probably be assuming too much and may have varying results across browsers.
Configuration menu - View commit details
-
Copy full SHA for 43d66d6 - Browse repository at this point
Copy the full SHA 43d66d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for f4c23b9 - Browse repository at this point
Copy the full SHA f4c23b9View commit details -
demo(dialog): add fields for minWidth, minHeight, maxWidth and maxHeight
Not adding `minWidth`, `minHeight`, `maxWidth` and `maxHeight` to `config` to avoid overriding the default value of `maxWidth` particularly—the type checker will require it to be a string. Instead, setting `config` to type `MatDialogConfig` is prefered to appease the type checker since those four properties are optional.
Configuration menu - View commit details
-
Copy full SHA for 0cc61ae - Browse repository at this point
Copy the full SHA 0cc61aeView commit details -
demo(dialog): address AOT issues
Appeases the AOT type checker for the template by extending `MatDialogConfig` to disallow `position` from being undefined, given that it’s optional. Guards cannot be set on the template because the values are bound to NgModel.
Configuration menu - View commit details
-
Copy full SHA for 3582d14 - Browse repository at this point
Copy the full SHA 3582d14View commit details -
Configuration menu - View commit details
-
Copy full SHA for a30dc0b - Browse repository at this point
Copy the full SHA a30dc0bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e69f7b - Browse repository at this point
Copy the full SHA 8e69f7bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b1c733 - Browse repository at this point
Copy the full SHA 2b1c733View commit details
Commits on Oct 5, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 3b40361 - Browse repository at this point
Copy the full SHA 3b40361View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.