Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dialog): support minWidth, minHeight, maxWidth and maxHeight #7488

Merged
merged 8 commits into from
Oct 9, 2017

Commits on Oct 3, 2017

  1. feat(dialog): support minWidth, minHeight, maxWidth and maxHeight

    * Adds Dialog support for `minWidth`, `minHeight`, `maxWidth` and `maxHeight` via config. Mostly delegates to Overlay.
    * Moves declared `max-width` on `. mat-dialog-container` stylesheet to be authored via `MatDialogConfig`, providing the same default `80vw` value. Without this change, there would likely be undesired layout results due to different constraints being set on the overlay container vs the nested the dialog container.
    * Added note on `minHeight` and `maxHeight` regarding the potential need to also set a `height` due to the rules around computed height resolution (https://www.w3.org/TR/CSS2/visudet.html#min-max-widths).  Any value set on `height` as a default would probably be assuming too much and may have varying results across browsers.
    emilio-martinez committed Oct 3, 2017
    Configuration menu
    Copy the full SHA
    43d66d6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f4c23b9 View commit details
    Browse the repository at this point in the history
  3. demo(dialog): add fields for minWidth, minHeight, maxWidth and maxHeight

    Not adding `minWidth`, `minHeight`, `maxWidth` and `maxHeight` to `config` to avoid overriding the default value of `maxWidth` particularly—the type checker will require it to be a string. Instead, setting `config` to type `MatDialogConfig` is prefered to appease the type checker since those four properties are optional.
    emilio-martinez committed Oct 3, 2017
    Configuration menu
    Copy the full SHA
    0cc61ae View commit details
    Browse the repository at this point in the history
  4. demo(dialog): address AOT issues

    Appeases the AOT type checker for the template by extending `MatDialogConfig` to disallow `position` from being undefined, given that it’s optional. Guards cannot be set on the template because the values are bound to NgModel.
    emilio-martinez committed Oct 3, 2017
    Configuration menu
    Copy the full SHA
    3582d14 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a30dc0b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8e69f7b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    2b1c733 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2017

  1. Configuration menu
    Copy the full SHA
    3b40361 View commit details
    Browse the repository at this point in the history