fix(): add exportAs to missing components #7392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
requested review from
andrewseguin,
crisbeto,
jelbourn,
josephperrott,
kara,
mmalerba and
tinayuangao
as code owners
googlebot
added
the
cla: yes
crisbeto
reviewed
Sep 28, 2017
devversion
force-pushed
the
fix/export-as-components
branch
from
c6280a5
to
0838828
Compare
|
@jelbourn @josephperrott Updated the PR and included some more components/directives |
devversion
added
pr: needs review
and removed
in progress
src/cdk/portal/portal-directives.ts
Outdated
| @@ -49,6 +49,7 @@ export class TemplatePortalDirective extends TemplatePortal<any> { | |||
| */ | |||
| @Directive({ | |||
| selector: '[cdkPortalHost], [portalHost]', | |||
| exportAs: 'cdkPortalHost, portalHost', | |||
There was a problem hiding this comment.
I believe the intention is to remove [portalHost] eventually right? If that is the case, should we not export as portalHost?
There was a problem hiding this comment.
Makes sense. Updated it
devversion
force-pushed
the
fix/export-as-components
branch
from
0838828
to
aded123
Compare
josephperrott
approved these changes
Oct 4, 2017
src/lib/form-field/form-field.ts
Outdated
| @@ -53,6 +53,7 @@ let nextUniqueId = 0; | |||
| moduleId: module.id, | |||
| // TODO(mmalerba): the input-container selectors and classes are deprecated and will be removed. | |||
| selector: 'mat-input-container, mat-form-field', | |||
| exportAs: 'matFormField, matInputContainer', | |||
There was a problem hiding this comment.
Since <mat-input-container> is being deprecated, should we not include it in exportAs
There was a problem hiding this comment.
Makes sense. Removed it
* Adds the `exportAs` option to the missing components inside of Angular Material Fixes angular#7361
devversion
force-pushed
the
fix/export-as-components
branch
from
aded123
to
9e7692e
Compare
josephperrott
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exportAsoption to the missing components inside of Angular Material@jelbourn @josephperrott A few components/directives have been skipped because they were not added to the list in #7361. e.g. the
MdStepperor basically all the CDK directives of the table/stepper.Note: Adding the
exportAsto thevalidate-decoratorsTSLint rule is not a solution right now. There are too many components/directives that shouldn't specify anexportAs. @crisbeto we can chat about this.Fixes #7361