Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(snack-bar): subsequent snack bars not opening; animation issues #7086

Merged
merged 1 commit into from
Sep 29, 2017
Merged

fix(snack-bar): subsequent snack bars not opening; animation issues #7086

merged 1 commit into from
Sep 29, 2017

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Sep 14, 2017 •
edited
Loading

  • Fixes subsequent snack bars not showing up if they are opened while another snack bar is open. This was due to the latter snack bar getting closed immediately, because one of the animation events coming in as void->void.
  • Simplifies the logic for determining the animation state. Using the getter ended up returning an invalid state in some cases (e.g. undefined-top or undefined-bottom).

Fixes #7063.

@crisbeto
fix(snack-bar): subsequent snack bars not opening; animation issues
6ee2c34 
* Fixes subsequent snack bars not showing up if they are opened while another snack bar is open. This was due to the latter snack bar getting closed immediately, because one of the animation events coming in is `void->void`.
* Simplifies the logic for determining the animation state. Using the getter ended up passing returning an invalid state in some cases (e.g. `undefined-top` or `undefined-bottom`).

Fixes angular#7063.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 14, 2017
josephperrott
josephperrott approved these changes Sep 14, 2017
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker pr: lgtm and removed pr: needs review labels Sep 14, 2017
@andrewseguin andrewseguin merged commit 8e77261 into angular:master Sep 29, 2017
@willshowell willshowell mentioned this pull request Oct 3, 2017
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@josephperrott josephperrott

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MdSnackBar from Component auto-close, won't open
4 participants
@crisbeto @josephperrott @googlebot @andrewseguin