feat(selection-model): de/select multiple values at the same time #7001
Conversation
devversion
requested review from
andrewseguin,
crisbeto and
jelbourn
as code owners
googlebot
added
the
cla: yes
src/cdk/collections/selection.ts
Outdated
| @@ -162,6 +164,13 @@ export class SelectionModel<T> { | |||
| this._selection.forEach(value => this._unmarkSelected(value)); | |||
| } | |||
| } | |||
|
|
|||
| /** Throws an error if multiple values are passed into a selection model with a single value. */ | |||
| private _warnMultipleValuesForSingleSelection(values: T[]) { | |||
There was a problem hiding this comment.
I don't think the name is too accurate since it'll throw an error, not warn.
src/cdk/collections/selection.ts
Outdated
|
|
||
| /** Throws an error if multiple values are passed into a selection model with a single value. */ | ||
| export function throwMultipleValuesInSingleSelectionError() { | ||
| throw Error('Cannot pass multiple values into SelectionModel with single-value mode.'); |
There was a problem hiding this comment.
Since it is only being used in one place, consider moving this it into _warnMultipleValuesForSingleSelection?
There was a problem hiding this comment.
I think we have a convention that we create functions for these errors and re-export the Error object.
e.g in https://github.com/angular/material2/blob/master/src/lib/select/select-errors.ts#L28
Updating to follow that convention
There was a problem hiding this comment.
Those errors are in a function so we can use them in tests. If it's a one-off, it's fine to have it inline.
src/cdk/collections/selection.ts
Outdated
| @@ -182,6 +185,6 @@ export class SelectionChange<T> { | |||
| } | |||
|
|
|||
| /** Throws an error if multiple values are passed into a selection model with a single value. */ | |||
There was a problem hiding this comment.
Comment is inaccurate now. It returns an error instead of throwing it.
devversion
force-pushed
the
feat/selection-model-multiple-values
branch
from
6615c9a
to
b629c15
Compare
devversion
added
the
P2
Adds support for passing multiple values to the SelectionModel at the same time. This feature is described in the JSDoc already, but just wasn't implemented yet. This functionality gives us more control about the `onChange` event, which will otherwise fire every time if for example multiple values need to be selected.
devversion
force-pushed
the
feat/selection-model-multiple-values
branch
from
b629c15
to
980ce23
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Adds support for passing multiple values to the SelectionModel at the same time. This feature is described in the JSDoc already, but just wasn't implemented yet.
This functionality gives us more control about the
onChangeevent, which will otherwise fire every time if for example multiple values need to be selected.Related to #6896