Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(menu): multiple close events for a single close #6961

Merged
merged 3 commits into from
Sep 12, 2017
Merged

fix(menu): multiple close events for a single close #6961

merged 3 commits into from
Sep 12, 2017

Commits on Sep 10, 2017

  1. fix(menu): multiple close events for a single close 

    Don't emit a closed event when another event will be emitted. Previously, if one clicked on a menu item, one would get two events: `undefined` and `click` in that order. One would see similar behavior for `keydown` or clicking the backdrop. Unit tests were updated to prevent a regression.
    @ppham27
    ppham27 committed Sep 10, 2017
    Configuration menu
    Copy the full SHA
    1f9f761 View commit details
    Browse the repository at this point in the history

  2. Responding to review comments from @crisbeto

    @ppham27
    ppham27 committed Sep 10, 2017
    Configuration menu
    Copy the full SHA
    50d3214 View commit details
    Browse the repository at this point in the history

  3. Observable.empty() -> Observable.of() 

    _closeMenu -> _destroyMenu
    @ppham27
    ppham27 committed Sep 10, 2017
    Configuration menu
    Copy the full SHA
    a396846 View commit details
    Browse the repository at this point in the history