Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dialog): multiple dialogs not opening with disabled animations #6736

Closed
wants to merge 1 commit into from
Closed

fix(dialog): multiple dialogs not opening with disabled animations #6736

wants to merge 1 commit into from

Commits on Sep 30, 2017

  1. fix(dialog): multiple dialogs not opening with disabled animations 

    With SHA 36f708c, second dialogs can be only opened if the first dialog finished animating.

Due to the recent update to Angular 4.3, the animation trigger callbacks are firing in a wrong order (done callback fires before start), which causes the _isAnimating property to be set to true while the animation already finished.

@crisbeto Not too happy how the tests ended up.

Fixes angular#6719
    @devversion
    devversion committed Sep 30, 2017
    Configuration menu
    Copy the full SHA
    b13ceca View commit details
    Browse the repository at this point in the history