Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add root to the sourcemap so it won't use absolute pathing #636

Merged
merged 1 commit into from
Jun 10, 2016

Conversation

hansl
Copy link
Contributor

@hansl hansl commented Jun 5, 2016

Fixes #541, I think.

Need to chat to @jelbourn to try to see if that fixes the release itself, not jsut local.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 5, 2016
@hansl hansl force-pushed the fix-source-map branch 2 times, most recently from 06a8eca to 2ba0674 Compare June 7, 2016 00:50
@hansl
Copy link
Contributor Author

hansl commented Jun 7, 2016

This requires the latest release of the CLI to get angular/angular-cli#1028.

@hansl
Copy link
Contributor Author

hansl commented Jun 7, 2016

Also fix prod builds, which actually don't make sense for material, but 🤷

@jelbourn
Copy link
Member

I'm going to merge this since it's better, but I think the sourceMaps still aren't exactly right.

@jelbourn jelbourn merged commit f7bf148 into angular:master Jun 10, 2016
@danrasmuson
Copy link

Thanks guys. We hit this yesterday.

@jelbourn jelbourn mentioned this pull request Jun 20, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

release: incorrect sourcemaps
4 participants