Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(input): set proper role on md-error #6259

Merged
merged 2 commits into from
Aug 4, 2017
Merged

fix(input): set proper role on md-error #6259

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
538bd81
fix(input): set proper role on md-error
crisbeto Aug 3, 2017
38c70b4
Merge branch 'master' into md-error-role
tinayuangao Aug 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/lib/input/input-container.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -813,6 +813,14 @@ describe('MdInputContainer with forms', () => {
.toBe(1, 'Expected one hint to still be shown.');
});
}));

it('should set the proper role on the error messages', () => {
testComponent.formControl.markAsTouched();
fixture.detectChanges();

expect(containerEl.querySelector('md-error')!.getAttribute('role')).toBe('alert');
});

});

describe('custom error behavior', () => {
Expand Down
3 changes: 2 additions & 1 deletion src/lib/input/input-container.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,8 @@ export class MdHint {
@Directive({
selector: 'md-error, mat-error',
host: {
'class': 'mat-input-error'
'class': 'mat-input-error',
'role': 'alert',
}
})
export class MdErrorDirective { }
Expand Down