feat(chips): Add user defined tab index to chip list #6073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tinayuangao
added
pr: needs review
and removed
cla: yes
tinayuangao
force-pushed
the
chips-tabindex
branch
from
507b136
to
db164c8
Compare
googlebot
added
the
cla: yes
jelbourn
approved these changes
Aug 21, 2017
src/lib/chips/chip-list.ts
Outdated
| @@ -76,6 +76,10 @@ export class MdChipList implements AfterContentInit, OnDestroy { | |||
| /** Tab index for the chip list. */ | |||
| _tabIndex = 0; | |||
|
|
|||
| /** User defined tab index. | |||
| * When it is not null, use user defined tab index. Otherwise use _tabIndex */ | |||
There was a problem hiding this comment.
Formatting on the JsDoc is slightly off; should either be one line or formatted like
/**
* First line of the comment and
* the second line of the comment
*/
|
Add merge-ready when you're ready |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6069