Please start providing context for nuanced config settings.

[ghost]

Every config I have seen lacks context. When dealing with complex configs, we need to start providing the settings around the configuration options of interest in case other passer-bys are looking for where to include these specific and nuanced settings. This is the only page that talks about scss being used in angular-cli.json

[ghost]

@mmalerba Why is travis-ci linter failing? This isn't a code change it's a documentation change.

[mmalerba]

@megamindbrian looks like a lint error that was accidentally merged into master a while back. It has since been fixed and will probably go away if you rebase

[ghost]

@mmalerba How do I rebase a commit made through Githubs editor? All the changes are stored online so I don't have a separate branch. How do I checkout megamindbrian:patch-1 when it doesn't show in the history?
Looks like you can do this (I don't have the authority):

[mmalerba]

I'll just ignore the lint issue warning merge after this is LGTM'd, since it's clearly unrelated to your changes

[ghost]

Great!

…

On Tue, Aug 8, 2017 at 1:32 PM, mmalerba ***@***.***> wrote: I'll just ignore the lint issue warning merge after this is LGTM'd, since it's clearly unrelated to your changes — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6068 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AX5XbqlzM4so4q0CGT0zkHFFFcGJ-s5gks5sWMXHgaJpZM4OkWTl> .

[jelbourn]

I don't think this is the place to describe what the config file should look like; that level of detail belongs to the angular-cli documentation

[ghost]

You're wrong. What is there is meaningless without context. Showing that the angular/material2 theme can be imported by the styles: [] section of config is your responsibility since it is already on the page, and it is meaningless without context. It's also hard to read the way it currently exists.

…

On Thu, Aug 17, 2017 at 10:39 AM, Jeremy Elbourn ***@***.***> wrote: Closed #6068 <#6068>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6068 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AX5XbkpvobCyGvzyMa0sBPokDkEZqWKHks5sZHrrgaJpZM4OkWTl> .

[willshowell]

If you are using the Angular CLI, support for compiling Sass to css is built-in; you only have to add a new entry to the "styles" list in angular-cli.json pointing to the theme file (e.g., unicorn-app-theme.scss).

@megamindbrian what context is missing? That paragraph tells you

1. What entry you need to add
2. What file you need to add it to
3. Where in that file you should add it

The only improvement I could see is changing angular-cli.json to .angular-cli.json to match recent cli updates.

[ghost]

Where is styles?

…

On Thu, Aug 17, 2017 at 12:35 PM, Will Howell ***@***.***> wrote: If you are using the Angular CLI, support for compiling Sass to css is built-in; you only have to add a new entry to the "styles" list in angular-cli.json pointing to the theme file (e.g., unicorn-app-theme.scss ). @megamindbrian <https://github.com/megamindbrian> what context is missing? That paragraph tells you 1. What entry you need to add 2. What file you need to add it to 3. Where in that file you should add it The only improvement I could see is changing angular-cli.json to .angular-cli.json to match recent cli updates. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6068 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AX5XbtM2sGwCbE4Os5xj3C-yIUH7hUuhks5sZJYSgaJpZM4OkWTl> .

[willshowell]

in angular-cli.json

[ghost]

What entry you need to add
What file you need to add it to
Where in that file you should add it

@willshowell The current instructions don't represent the final result. Those 3 statements in 1 sentence don't look like a configuration. No matter what your argument is, a sentence:

If you are using the Angular CLI, support for compiling Sass to css is built-in; you only have to add a new entry to the "styles" list in angular-cli.json pointing to the theme file (e.g., unicorn-app-theme.scss).

Does not look like a config change. Why shouldn't documentation follow the same SOLID principles that code does? Documentation should look like the expected result.

{
    "apps": [
        {
            "name": "unicorn-app",
            ... main, polyfills, etc
        },
        "styles": [
            "unicorn-app-theme.scss"
        ]
    ]
}

{
    "apps": [
        {
            "name": "unicorn-app",
            ... main, polyfills, etc
        }
    ],
    "styles": [
        "unicorn-app-theme.scss"
    ]
}

{
    "defaults": {
        "styles": [
            "unicorn-app-theme.scss"
        ]
    }
}

{
    "project": {
        "styles": [
            "unicorn-app-theme.scss"
        ]
    }
}

When I scroll though the page and I see a code block, I think "Oh! That must be a config change!". When I scroll through and I see 1 line out of hundreds that describes the name of the file, that line does not look like a config change. That looks like some arbitrary instructions. You could even number the steps if that would be better.

[ghost]

#6530

[ghost]

#4125 (comment)

[p3x-robot]

this scss is still not fixed. :( no matter i do i get this, i use 9 themes, all dynamic, the aot built no warning but in dev it shows warning and i do use the @mat-core, i even include every where.

does it only work angular-cli or what, i use the exact theme guide , still the warning keeps.
what can i do? i see my questions is closed, but the "warning" kept.
ok it works but ok, why do i get a warning without i created the themes guide.

i just use webpack. that's all plus angular-compiler, with or without styleUrls....

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}