Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add tabs, expansion, and paginator to kitchen-sink #5342

Closed
wants to merge 1 commit into from
Closed

chore: add tabs, expansion, and paginator to kitchen-sink #5342

wants to merge 1 commit into from

Conversation

jelbourn
Copy link
Member

No description provided.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 24, 2017
tinayuangao
tinayuangao approved these changes Jun 24, 2017
View reviewed changes
Copy link
Contributor

@tinayuangao tinayuangao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn
Copy link
Member Author

Hmm, the prerender task fails on Travis. Perhaps this has to do with the Angular version...

@crisbeto
Copy link
Member

It's failing because tabs don't work with server-side rendering (there's a comment about it in the kitchen sink). #5348 will fix it.

@jelbourn
Copy link
Member Author

@crisbeto Yeah, I had seen that tabs didn't work before (I wrote the comment), but when I ran this PR on my machine everything worked.

@jelbourn jelbourn closed this Jul 13, 2017
@jelbourn jelbourn deleted the more-prerender branch April 2, 2018 22:30
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tinayuangao tinayuangao tinayuangao approved these changes

Assignees
No one assigned
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jelbourn @crisbeto @tinayuangao @googlebot