fix(menu): role being set on the wrong element #5191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
Accessibility
googlebot
added
the
cla: yes
kara
approved these changes
Jun 19, 2017
src/lib/menu/menu.spec.ts
Outdated
| fixture.componentInstance.trigger.openMenu(); | ||
| fixture.detectChanges(); | ||
|
|
||
| expect(overlayContainerElement.querySelector('[role="menu"]')) |
There was a problem hiding this comment.
Any reason why we're not using getAttribute here to check directly?
There was a problem hiding this comment.
This was a little shorter. I'll switch to a querySelector and getAttribute.
Currently, the `menu` role is set on the `md-menu` directive, however the it is inert and won't get rendered inside the overlay. These changes remove the `menu` role from the inert element and set it on the element that will get rendered inside the overlay.
crisbeto
force-pushed
the
menu-wrong-role-location
branch
from
6c05288
to
c292dd7
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
menurole is set on themd-menudirective, however the it is inert and won't get rendered inside the overlay. These changes remove themenurole from the inert element and set it on the element that will get rendered inside the overlay.