Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(radio): support for color binding #5068

Merged
merged 1 commit into from
Jun 13, 2017

Conversation

devversion
Copy link
Member

  • Introduces the color binding for radio buttons. By default every selection control uses accent as per Material design specifications.

Closes #4677

* Introduces the `color` binding for radio buttons. By default every selection control uses accent as per Material design specifications.

Closes angular#4677
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 11, 2017
Copy link
Contributor

@tinayuangao tinayuangao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Jun 12, 2017
@kara kara merged commit 82d752b into angular:master Jun 13, 2017
@devversion devversion deleted the feat/radio-color-theming branch November 11, 2017 10:23
@chriszrc
Copy link

chriszrc commented Jan 5, 2018

💯
Nice!!! Seems this hasn't made it to the docs though :'(

@devversion
Copy link
Member Author

@chriszrc Sorry for that. Since the color, tabIndex, rippleDisabled properties are mostly created by mixin functions to reduce the payload of Angular Material.. those aren't showing up in the API docs (yet).

We definitely want to fix that, but our docs generation tool is not yet able to understand such mixins, because it kind of isn't statically analyzable. Tracking this issue with #5284

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

md-radio color support
5 participants