Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(list): adds focus state for nav-list items #502

Merged
merged 1 commit into from
May 23, 2016
Merged

fix(list): adds focus state for nav-list items #502

merged 1 commit into from
May 23, 2016

Conversation

robertmesserle
Copy link
Contributor

closes #323

Note: More discussion needed on list items with multiple actions.

R: @jelbourn @kara

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 23, 2016
@@ -56,6 +63,18 @@ export class MdListItem implements AfterContentInit {

constructor(private _renderer: Renderer, private _element: ElementRef) {}

/** @internal */
handleFocus() {
console.log('focus');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the console.logs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. Will do.

On Mon, May 23, 2016 at 3:37 PM, Kara [email protected] wrote:

In src/components/list/list.ts
#502 (comment):

@@ -56,6 +63,18 @@ export class MdListItem implements AfterContentInit {

constructor(private _renderer: Renderer, private _element: ElementRef) {}

  • /** @internal */
  • handleFocus() {
  • console.log('focus');

Remove the console.logs?


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/angular/material2/pull/502/files/c4569f49304bd970403d10a1e86325d85ac641ce#r64301388

closes #323

Note: More discussion needed on list items with multiple actions.
@jelbourn
Copy link
Member

LGTM

@jelbourn jelbourn merged commit 34b210c into angular:master May 23, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add focus styling for anchors in md-nav-list
4 participants