feat: expose version object in releases #4962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Before we merge this, I need to talk to @vikerman about how this version gets updated for Angular when doing the sync into Google. |
devversion
force-pushed
the
feat/expose-version-object
branch
2 times, most recently
from
3bd323e
to
c6fbbf7
Compare
|
Rebased. |
devversion
force-pushed
the
feat/expose-version-object
branch
from
c6fbbf7
to
2dd6b6c
Compare
|
I love this PR. Need this in Flex-Layout! |
devversion
force-pushed
the
feat/expose-version-object
branch
from
2dd6b6c
to
ba68848
Compare
devversion
force-pushed
the
feat/expose-version-object
branch
2 times, most recently
from
99112f9
to
8d6bc8c
Compare
devversion
force-pushed
the
feat/expose-version-object
branch
from
8d6bc8c
to
2e71249
Compare
|
@jelbourn Any updates on this one? |
|
Every time I remember it @vikerman is away from his desk. |
|
Finally followed up on this- no action needed on your part. Will be good to merge after my cdk entry-points PR (version will be the only thing under |
devversion
force-pushed
the
feat/expose-version-object
branch
from
2e71249
to
9d840c3
Compare
|
@jelbourn Rebased. Please have another look. |
jelbourn
reviewed
Jul 26, 2017
| @@ -0,0 +1,32 @@ | |||
| import {readFileSync, writeFileSync} from 'fs'; | |||
There was a problem hiding this comment.
Why does this code exist twice?
There was a problem hiding this comment.
Good question. Looks like the old one before the build changes is still there after rebasing.
* In releases there will be a constant called `VERSION` that holds the current version of the installed package (material or cdk) * This is similar as for every @angular package like core, forms, compiler.
devversion
force-pushed
the
feat/expose-version-object
branch
from
9d840c3
to
bb043ce
Compare
jelbourn
reviewed
Jul 26, 2017
|
|
||
| fileContent = fileContent.replace(versionPlaceholderRegex, buildConfig.projectVersion); | ||
|
|
||
| writeFileSync(filePath, fileContent); |
There was a problem hiding this comment.
Does this writeFileSync need 'utf-8'?
There was a problem hiding this comment.
writeFileSync always defaults to UTF-8 as encoding (reference)
tinayuangao
pushed a commit
to tinayuangao/material2
that referenced
this pull request
Jul 27, 2017
* In releases there will be a constant called `VERSION` that holds the current version of the installed package (material or cdk) * This is similar as for every @angular package like core, forms, compiler. Add accessibility demo page for grid list .
tinayuangao
pushed a commit
to tinayuangao/material2
that referenced
this pull request
Jul 28, 2017
* In releases there will be a constant called `VERSION` that holds the current version of the installed package (material or cdk) * This is similar as for every @angular package like core, forms, compiler. Add accessibility demo page for grid list .
andrewseguin
pushed a commit
that referenced
this pull request
Jul 29, 2017
* In releases there will be a constant called `VERSION` that holds the current version of the installed package (material or cdk) * This is similar as for every @angular package like core, forms, compiler. Add accessibility demo page for grid list .
tinayuangao
pushed a commit
to tinayuangao/material2
that referenced
this pull request
Jul 31, 2017
* In releases there will be a constant called `VERSION` that holds the current version of the installed package (material or cdk) * This is similar as for every @angular package like core, forms, compiler. Add accessibility demo page for grid list .
tinayuangao
pushed a commit
that referenced
this pull request
Aug 1, 2017
* In releases there will be a constant called `VERSION` that holds the current version of the installed package (material or cdk) * This is similar as for every @angular package like core, forms, compiler. Add accessibility demo page for grid list .
tinayuangao
pushed a commit
to tinayuangao/material2
that referenced
this pull request
Aug 1, 2017
* In releases there will be a constant called `VERSION` that holds the current version of the installed package (material or cdk) * This is similar as for every @angular package like core, forms, compiler. Add accessibility demo page for grid list .
tinayuangao
added a commit
that referenced
this pull request
Aug 1, 2017
* real world example * remove roles * feat: expose version object in releases (#4962) * In releases there will be a constant called `VERSION` that holds the current version of the installed package (material or cdk) * This is similar as for every @angular package like core, forms, compiler. Add accessibility demo page for grid list . * change header and add roles
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VERSIONthat holds the current version of the installed package (material or cdk)