Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icon): remove automatic aria labelling and add a11y guidance #4665

Merged
merged 1 commit into from
Jun 8, 2017

Commits on Jun 8, 2017

  1. fix(icon): remove automatic aria labelling and add a11y guidance

    The automatic application of aria-label for md-icon, in hindsight, was
    not a great idea. Neither the ligature string nor the SVG filename are
    likely to be meaningful descriptions. Even in cases where they *are*,
    the icon may be used in such a way that the application of a label is
    still the wrong thing. On top of that, adding `role="img"` is usually
    not the right approach for an icon, as that role typically refers to
    *content* images, rather than icons that are part of the UI.
    
    Ultimately, it is up to the application developer to add the appropriate
    meaning for icons based on how they're used. To this end, we add
    guidance to the documentation for what to do in different situations.
    jelbourn committed Jun 8, 2017
    Configuration menu
    Copy the full SHA
    b50ee7b View commit details
    Browse the repository at this point in the history