Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(connected-overlay): better handling of dynamic content #4250

Merged
merged 2 commits into from
May 4, 2017
Merged

fix(connected-overlay): better handling of dynamic content #4250

merged 2 commits into from
May 4, 2017

Commits on May 3, 2017

  1. fix(connected-overlay): better handling of dynamic content 

    * Refactors the `ConnectedPositionStrategy` to be able to use `right` and `bottom` to position the panel. This will allow the element to keep its position automatically, even if the element's size changes.
* Removes the uses of the `FakeViewportRuler` in some of the unit tests since it doesn't work very well when the element is positioned relatively to the right edge of the screen.
* Rounds down the values when testing positioning. This is necessary, because some browsers (particularly Chrome on Windows) can have some subpixel deviations.

Fixes angular#4155.
    @crisbeto
    crisbeto committed May 3, 2017
    Configuration menu
    Copy the full SHA
    057603e View commit details
    Browse the repository at this point in the history

  2. refactor: move new logic into _setElementPosition method

    @crisbeto
    crisbeto committed May 3, 2017
    Configuration menu
    Copy the full SHA
    ad153c2 View commit details
    Browse the repository at this point in the history