Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fix multi theme select #4153

Closed
wants to merge 2 commits into from

Conversation

xmeng1
Copy link

@xmeng1 xmeng1 commented Apr 19, 2017

Try to fix the bug #4077 for Input/Select/Slider/Tabs

I have converted the '&' in SCSS for input/select/slider/tabs and I have tested on my demo (use build of myself)

Demo:
https://ng2-material-admin.firebaseapp.com/
Demo repo:
https://github.com/xmeng1/ng2-material-admin

The build repo
https://github.com/xmeng1/material2-builds

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Apr 19, 2017
@xmeng1
Copy link
Author

xmeng1 commented Apr 19, 2017

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Apr 19, 2017
@xmeng1
Copy link
Author

xmeng1 commented Apr 19, 2017

I just see that @crisbeto has fix it. sorry.

@jelbourn
Copy link
Member

Yeah, @crisbeto already added a fix for this and a lint check to ensure it doesn't happen again- thanks anyway!

@jelbourn jelbourn closed this Apr 19, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants