fix(autocomplete): panel not being shown with delay and OnPush change detection #3977
Conversation
… detection Fixes an issue that prevented the autocomplete panel from being shown if the options are initialized with a delay in a component that has `OnPush` change detection. Fixes angular#3955.
googlebot
added
the
cla: yes
| let visibleClass = 'mat-autocomplete-visible'; | ||
|
|
||
| fixture.detectChanges(); | ||
| expect(panel.classList).toContain(visibleClass, `Expected panel to be visible.`); |
There was a problem hiding this comment.
Does this Promise ever resolve? Don't you need another flushMicroTasks to make it run?
There was a problem hiding this comment.
I believe that the tick calls flushMicrotasks under the hood.
There was a problem hiding this comment.
Yeah a tick should automatically clear the event-loop queue.
There was a problem hiding this comment.
What I mean is that you're calling tick before kicking off the promise.
There was a problem hiding this comment.
Reconfirmed that it resolves and the test breaks as expected if I remove the newly-added markForCheck.
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes an issue that prevented the autocomplete panel from being shown if the options are initialized with a delay in a component that has
OnPushchange detection.Fixes #3955.