Fix(md-menu) : Added prevent close( when user clicks inside menu panel) feature.

[ravinderpayal]

As It's a feature the core team decided to add, and I was in need of this feature for functionality like drop-down menu having some setting controls where user may want to change multiple settings in one go. As currently after every click inside or outside of drop-down menu, it disappears. But adding some additional check based on the value of preventClose @input() supplied parent node can add this desired functionality. Actually I am creating a emoji picker, and have multiple categories of emoji, so user is required to change the category by clicking on tabs(Yeah I am using MD-tabs), menu disappears so this feature will help in accomplishing my specific requirement, and other people's similar requirements.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.

[ravinderpayal]

Signed in

…

On Tue, Apr 4, 2017, 9:54 PM googlebot ***@***.***> wrote: Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 *Please visit https://cla.developers.google.com/ <https://cla.developers.google.com/> to sign.* Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks. ------------------------------ - If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data <https://cla.developers.google.com/clas> and verify that your email is set on your git commits <https://help.github.com/articles/setting-your-email-in-git/>. - If you signed the CLA as a corporation, please let us know the company's name. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3897 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFbP0lOUexHu0TEnRCaY170gBY8kHmvWks5rsm66gaJpZM4MzGqH> .

[googlebot]

CLAs look good, thanks!

[willshowell]

Hey @ravinderpayal, as a heads up, the team will certainly ask for tests to verify the behavior of the api change.

You should also try to get your linting issues fixed before review. It looks like a couple of the comments are unnecessary / not formatted correctly.

Additionally, consider using disableClose to match the api for MdDialogConfig (not necessary, just a thought).

Finally, it would be a good idea to explain your motivation behind the change in your original comment!

[ravinderpayal]

@willshowell Thanks Sir, I will consider your thoughts, and thanks one more time for clearing my doubts about failure of travis build.

[ravinderpayal]

Travis Build Passed, and @wilshowell I have kept the preventClose as it is, because disableClose mean something like completely disabling the close, while we are preventing close only when user click inside the panel.

[willshowell]

As a few more notes, JSDoc comments (/** */) should only be used for api purposes (like preventClose and toggleMenu) while you should use standard line comments (//) elsewhere.

Again, tests will be required by the team, so you should add those too.

Good luck with your PR!

[ravinderpayal]

Ok brother

…

On Wed, Apr 5, 2017, 7:39 PM Will Howell ***@***.***> wrote: As a few more notes, JSDoc comments (/** */) should only be used for api purposes (like preventClose and toggleMenu) while you should use standard line comments (//) elsewhere. Again, tests will be required by the team, so you should add those too. Good luck with your PR! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3897 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFbP0gitXbI8D41NRKGTT0VU92hTRrXMks5rs6CEgaJpZM4MzGqH> .

[agostinalucia]

👏

[zmanring-zz]

I need this! :D Thank you @ravinderpayal

[ravinderpayal]

While working on some other project I found a better option, let me patch mine code.

[ravinderpayal]

@zmanring @agostinalucia @mprobst @willshowell I have created a fresh pull request after testing working of code. This current commits are not required. I have added preventClose input/attribute on <md-menu> component itself, but before it's was required to add preventClose on trigger component/element.

#4354

[jelbourn]

Closing since this is now quite stale. I think this feature has come up a few times in issue discussion and we've decided that we wouldn't want to add this option to mat-menu since it would go against W3C a11y recommendations.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}