Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dialog): delay focus until animation is done #3774

Merged
merged 1 commit into from
Mar 29, 2017
Merged

fix(dialog): delay focus until animation is done #3774

merged 1 commit into from
Mar 29, 2017

Commits on Mar 24, 2017

  1. fix(dialog): delay focus until animation is done 

    Delays focusing the first tabbable element in a dialog until animation is done. This prevents issues where other components (e.g. autocomplete) may have a wrong position on load, because they measured dialog while it was animating.

Note on lack of tests: This is kind of hard to test, because we don't have much control over how the animations runs.

Fixes angular#3722.
    @crisbeto
    crisbeto committed Mar 24, 2017
    Configuration menu
    Copy the full SHA
    1c01bdd View commit details
    Browse the repository at this point in the history