fix(ripple): unable to remove programmatically if animations is ongoing #3398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is something I ran into while working on angular#3102. For persistent ripples, the `fadeOutAll` method doesn't work if it is called before the enter animation is finished. The issue was that the set of active ripples doesn't get populated until the animation is done. Relates to angular#3102.
googlebot
added
the
cla: yes
|
Chatting with @crisbeto about it - I intentionally didn't do that when refactoring the ripples, because now the ripples are fading-out immediately on mouseup. |
|
Closing this as per discussion with @devversion who had some plans for this already. |
devversion
added a commit
to devversion/material2
that referenced
this pull request
Mar 2, 2017
* When calling `fadeOutAll()`, all currently fading / animating ripples should hide as well. * Adds some extra tests that ensure that ripples properly fade-in and fade-out (See angular#3398)
devversion
added a commit
to devversion/material2
that referenced
this pull request
Mar 2, 2017
* When calling `fadeOutAll()`, all currently fading / animating ripples should hide as well. * Adds some extra tests that ensure that ripples properly fade-in and fade-out (See angular#3398)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something I ran into while working on #3102. For persistent ripples, the
fadeOutAllmethod doesn't work if it is called before the enter animation is finished. The issue was that the set of active ripples doesn't get populated until the animation is done.Relates to #3102.