-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(md-select): change the arrow position to absolute #3242
Conversation
…e the final width of md-select
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CSS changes LGTM, but a couple of notes:
- We don't need the extra demo.
- Can you please rebase and squash your commits?
src/demo-app/select/select-demo.html
Outdated
@@ -54,3 +54,27 @@ | |||
|
|||
</div> | |||
<div style="height: 500px">This div is for testing scrolled selects.</div> | |||
|
|||
<md-card> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need this example. The examples in the demo app are there to be able to click around the main use cases, they're not for actual testing.
Conflicts: src/demo-app/select/select-demo.ts
@crisbeto conflicts resolved and I've removed the demo for flex layout from the demo page. Anything else that needs to change here? |
Not code-wise, but you have a few merge conflicts which can cause issues with our scripts. Can you squash all your commits into one? |
Well, it's already done, but FYI you can still squash commits after the PR has been opened. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #3112