Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): update errorState example to cover handle missing state #30059

Merged
merged 1 commit into from
Nov 22, 2024
Merged

fix(docs): update errorState example to cover handle missing state #30059

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions guides/creating-a-custom-form-field-control.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,14 +357,14 @@ ngDoCheck() {
}

private updateErrorState() {
const parent = this._parentFormGroup || this.parentForm;
const parentSubmitted = this._parentFormGroup?.submitted || this._parentForm?.submitted;
const touchedOrParentSubmitted = this.touched || parentSubmitted;

const oldState = this.errorState;
const newState = (this.ngControl?.invalid || this.parts.invalid) && (this.touched || parent.submitted);
const newState = (this.ngControl?.invalid || this.parts.invalid) && touchedOrParentSubmitted;

if (oldState !== newState) {
if (this.errorState !== newState) {
this.errorState = newState;
this.stateChanges.next();
this.stateChanges.next(); // Notify listeners of state changes.
}
}
```
Expand Down
Loading