Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(material/schematics): Add CSS output to custom theme schematic #30004

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amysorto
Copy link
Contributor

@amysorto amysorto commented Nov 13, 2024

Fixes #29363

@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Nov 13, 2024
@amysorto amysorto force-pushed the schematic-css-output branch 2 times, most recently from 06fd9dd to c844199 Compare November 15, 2024 18:32
@amysorto amysorto added the target: patch This PR is targeted for the next patch release label Nov 15, 2024
@amysorto amysorto marked this pull request as ready for review November 15, 2024 18:40
@amysorto amysorto requested a review from a team as a code owner November 15, 2024 18:40
@amysorto amysorto requested review from wagnermaciel and removed request for a team November 15, 2024 18:40
@amysorto amysorto added dev-app preview When applied, previews of the dev-app are deployed to Firebase and removed dev-app preview When applied, previews of the dev-app are deployed to Firebase labels Nov 15, 2024
Copy link

Deployed dev-app for c844199 to: https://ng-dev-previews-comp--pr-angular-components-30004-dev-g66rq78f.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

This schematic allows users to create new Material 3 theme palettes based
on custom colors by using [Material Color Utilities](https://github.com/material-foundation/material-color-utilities).
This is an alternative to using the available [predefined theme palettes](https://material.angular.io/guide/theming#prebuilt-color-palettes).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This theming guide link no longer points to a specific section (in next.material.angular.io) - this and other spots in the README that need to be adjusted

The new theming guide doesnt really list out the prebuilts anymore. I feel like they might be outdated now that its so easy to add your own theme with mat.theme

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was looking at the rc guide but just removed the rc in the url since the target for this PR is patch.

So this link for that is https://rc.material.angular.io/guide/theming#prebuilt-color-palettes, which does have the list of the prebuilt palettes. Should this still be removed?

src/material/schematics/ng-generate/theme-color/README.md Outdated Show resolved Hide resolved
src/material/schematics/ng-generate/theme-color/README.md Outdated Show resolved Hide resolved
src/material/schematics/ng-generate/theme-color/README.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
detected: feature PR contains a feature commit target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(theming): Replace SASS-Based theming with global CSS variables
2 participants