fix(material/core): change ng-add to use mat.theme #29990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewseguin
requested review from
crisbeto and
wagnermaciel
and removed request for
a team
andrewseguin
added
the
target: rc
mmalerba
approved these changes
Nov 8, 2024
|
|
||
| // Comment out the line below if you want to use the pre-defined typography utility classes. | ||
| // For more information: https://material.angular.io/guide/typography#using-typography-styles-in-your-application. | ||
| // @include mat.typography-hierarchy($${name}-theme); |
There was a problem hiding this comment.
Is there an equivalent for these optional bits with the new system? Or are we changing to a more opinionated stance of either automatically including these as part of the new mixin or just recommending not to use them?
There was a problem hiding this comment.
I prefer recommending that clients just depend on the system variables where they want them. For example they can make their own custom setup like:
h1 {
font: var(--mat-sys-headline-large);
}
h2 {
font: var(--mat-sys-headline-medium);
}
h3 {
font: var(--mat-sys-headline-small);
}
My hope is that we can get folks to generally just need to know about mat.theme and the available variables. This also seems to match with Material's departure from their previous opinionated typography names: https://m2.material.io/develop/web/guides/typography
andrewseguin
added a commit
that referenced
this pull request
Nov 11, 2024
* fix(material/core): change ng-add to use mat.theme * fix(material/core): tests --------- Co-authored-by: Andrew Seguin <[email protected]> (cherry picked from commit 0a5b036)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.