feat(datepicker): add calendar component that pulls together month and year views #2994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
styling still needs some love
tinayuangao
reviewed
Feb 14, 2017
| <div class="mat-calendar-spacer"></div> | ||
| <button class="mat-calendar-button mat-calendar-previous-button" (click)="_previousClicked()"> | ||
| <svg xmlns="http://www.w3.org/2000/svg" width="24px" height="24px" viewBox="0 0 24 24" | ||
| fill="#000000"> |
There was a problem hiding this comment.
Use css color instead of hard code in html? Why do we put this in a svg file?
There was a problem hiding this comment.
These are "keyboard arrow left" and "keyboard arrow right" from go/icons. I'd rather not mess with the contents of the svgs. I'm embedding them because its a pattern we already follow elsewhere in the code (I assume to avoid incurring additional resource requests). see: https://github.com/angular/material2/blob/master/src/lib/checkbox/checkbox.html#L24
src/lib/datepicker/calendar.spec.ts
Outdated
| import {By} from '@angular/platform-browser'; | ||
|
|
||
|
|
||
| describe('MsCalendar', () => { |
There was a problem hiding this comment.
nit: is it MdCalendar?
|
LGTM |
mmalerba
added a commit
that referenced
this pull request
Feb 27, 2017
…d year views (#2994) * create a calendar component that pulls together month and year views styling still needs some love * fix typo
mmalerba
added a commit
that referenced
this pull request
Mar 2, 2017
…d year views (#2994) * create a calendar component that pulls together month and year views styling still needs some love * fix typo
mmalerba
added a commit
to mmalerba/components
that referenced
this pull request
Mar 6, 2017
…d year views (angular#2994) * create a calendar component that pulls together month and year views styling still needs some love * fix typo
mmalerba
added a commit
that referenced
this pull request
Mar 17, 2017
…d year views (#2994) * create a calendar component that pulls together month and year views styling still needs some love * fix typo
mmalerba
added a commit
to mmalerba/components
that referenced
this pull request
Mar 28, 2017
…d year views (angular#2994) * create a calendar component that pulls together month and year views styling still needs some love * fix typo
mmalerba
added a commit
that referenced
this pull request
Apr 14, 2017
…d year views (#2994) * create a calendar component that pulls together month and year views styling still needs some love * fix typo
mmalerba
added a commit
that referenced
this pull request
Apr 20, 2017
…d year views (#2994) * create a calendar component that pulls together month and year views styling still needs some love * fix typo
mmalerba
added a commit
that referenced
this pull request
Apr 29, 2017
…d year views (#2994) * create a calendar component that pulls together month and year views styling still needs some love * fix typo
mmalerba
added a commit
that referenced
this pull request
May 5, 2017
…d year views (#2994) * create a calendar component that pulls together month and year views styling still needs some love * fix typo
mmalerba
added a commit
that referenced
this pull request
May 9, 2017
…d year views (#2994) * create a calendar component that pulls together month and year views styling still needs some love * fix typo
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
styling still needs some love