feat(material/schematics): Update custom theme schematic to work with light-dark and use theme-overrides mixin #29911
+95
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| override the system level variables with high contrast equivalent values from your theme. This is | ||
| helpful for users who prefer more contrastful colors for either preference or accessibility reasons. | ||
|
|
||
| ### Creating one theme for light and dark mode | ||
| As of v19, the `theme` mixin can create one theme that detects and adapts to a user if they have |
There was a problem hiding this comment.
We can work on this wording as we get closer to release. We'll sync up the messaging between the guide and this
| scss += ' ))\n'; | ||
| scss += '};\n'; | ||
|
|
||
| // Create high-contrast-light-theme-overrides and high-contrast-dark-theme-overrides mixins | ||
| for (const themeType of ['light', 'dark']) { |
There was a problem hiding this comment.
It looks like this outputs three mixins - should we have some param that lets the user decide whether they want to use the light-dark method, or specify light and dark?
amysorto
force-pushed
the
schematic-light-dark-changes
branch
2 times, most recently
from
f7e3c62
to
11cc5dd
Compare
… light-dark and use theme-overrides mixin
amysorto
force-pushed
the
schematic-light-dark-changes
branch
from
11cc5dd
to
14726d6
Compare
andrewseguin
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Schematic changes needed to work with #29907