fix(cdk/scrolling): virtual scroll flickers in zoneless mode. #29777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When provideExperimentalZonelessChangeDetection is enabled, virtual-scroll-viewport flickers during scroll because the transform operation becomes visible. This fix moves the style transform into the afterNextRender phase to ensure it stays invisible. Fixes angular#29174
jacob-noble
requested review from
crisbeto and
amysorto
and removed request for
a team
|
This is a sharp-looking pull request! |
|
This is exactly how it was in d91d0d4 before it was reverted due to an internal breakage and moved outside in 32d2683. This will require another round of unpacking the problem and re-evaluating potential solutions. IIRC, this one broke scrolling entirely in the app. Once scrolling started, it never stopped. |
|
@atscott - Thanks for taking the time to look at this. I wasn't aware that this was a solution that was tried previously. I haven't run into the issue where scrolling broke entirely yet (either in the local environment or in one of the projects I'm involved in that makes use of this fix as a patch). Do you know how to reproduce that issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
provideExperimentalZonelessChangeDetectionis enabled, virtual-scroll-viewport flickers during scroll because the transform operation becomes visible. This fix moves the style transform into theafterNextRenderphase to ensure it stays invisible.Fixes #29174