Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cdk/scrolling): resize viewport on content size changes #29667

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(cdk/scrolling): resize viewport on content size changes #29667

wants to merge 1 commit into from

Conversation

xetrics
Copy link

@xetrics xetrics commented Aug 29, 2024 •
edited
Loading

Implements resizing of the viewport of AutoSizeVirtualScrollStrategy when the content changes size. Currently, the viewport only resizes on scroll/data change events.

  • Do you agree with my strategy of watching viewport._contentWrapper for size changes?
  • Not sure if the attach method is the best place for this. Thoughts?
  • Would it make more sense to add a method to VirtualScrollStrategy and implement a handler in FixedSizeVirtualScrollStrategy/AutoSizeVirtualScrollStrategy?
  • Any mistakes you see so far or general changes that need to be made?

See #10117

@xetrics xetrics requested a review from a team as a code owner August 29, 2024 23:23
@xetrics xetrics requested review from crisbeto and mmalerba and removed request for a team August 29, 2024 23:23
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Aug 29, 2024
@xetrics
feat(cdk/scrolling): resize viewport on on content size changes
7b0c5ce 
Adds support for automatically re-calculating the viewport's size if content size changes.

Partially implements angular#10117
@xetrics xetrics changed the title feat(cdk/scrolling): resize viewport on on content size changes feat(cdk/scrolling): resize viewport on content size changes Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crisbeto crisbeto Awaiting requested review from crisbeto crisbeto is a code owner automatically assigned from angular/components-googlers

@mmalerba mmalerba Awaiting requested review from mmalerba mmalerba is a code owner automatically assigned from angular/components-googlers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
detected: feature PR contains a feature commit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xetrics