fix(material/datepicker): calendar font tokens not being picked up #29610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
requested review from
amysorto and
andrewseguin
and removed request for
a team
andrewseguin
approved these changes
Aug 20, 2024
crisbeto
force-pushed
the
29608/calendar-token
branch
from
17321aa
to
2c80ab9
Compare
We were setting the `calendar-text-font` and `calendar-text-size` tokens at the top level of the calendar which meant that it wasn't being picked up in the cells, because they have `button` elements which have user agent styles. These changes resolve the issue by explicitly setting the tokens. Also fixes that the font size was too big in M3. Fixes angular#29608.
crisbeto
force-pushed
the
29608/calendar-token
branch
from
2c80ab9
to
f4595b6
Compare
crisbeto
added
target: minor
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Aug 20, 2024
…ngular#29610) We were setting the `calendar-text-font` and `calendar-text-size` tokens at the top level of the calendar which meant that it wasn't being picked up in the cells, because they have `button` elements which have user agent styles. These changes resolve the issue by explicitly setting the tokens. Also fixes that the font size was too big in M3. Fixes angular#29608.
crisbeto
added a commit
that referenced
this pull request
Aug 21, 2024
…29610) (#29615) We were setting the `calendar-text-font` and `calendar-text-size` tokens at the top level of the calendar which meant that it wasn't being picked up in the cells, because they have `button` elements which have user agent styles. These changes resolve the issue by explicitly setting the tokens. Also fixes that the font size was too big in M3. Fixes #29608.
This was referenced Sep 13, 2024
This was referenced Sep 14, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were setting the
calendar-text-fontandcalendar-text-sizetokens at the top level of the calendar which meant that it wasn't being picked up in the cells, because they havebuttonelements which have user agent styles.These changes resolve the issue by explicitly setting the tokens.
Also fixes that the font size was too big in M3.
Fixes #29608.